Make generic_trimatmul more specific #2359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently implementing a generic version of
generic_trimatmul
JuliaGPU/GPUArrays.jl#531.The GPUArrays test suite keeps failing for CUDA, AMDGPU and oneAPI though: https://buildkite.com/julialang/gpuarrays-dot-jl/builds/861#018f3433-15d5-4251-8a39-9a37d194eb22
So I would like to make the function signature of
generic_trimatmul
in CUDA.jl a bit more specific to be inline withtrsv!
to whichgeneric_trimatmul
dispatches (for vectors).