Replace slash by path separator to properly skip tests on Windows. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
bugfix
maleadt
force-pushed
the
tb/runtest_path_separator
branch
2 times, most recently
from
feefdc7
to
f4a4f06
Compare
maleadt
force-pushed
the
tb/runtest_path_separator
branch
from
f4a4f06
to
9a76818
Compare
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 82.35% 82.38% +0.02%
==========================================
Files 145 145
Lines 9441 9450 +9
==========================================
+ Hits 7775 7785 +10
+ Misses 1666 1665 -1
Continue to review full report at Codecov.
|
|
@maleadt On re-running test CUDA after the latest commit, there is absolutely no difference in the error message with respect to my first posting. |
|
Do you still see both |
|
Yes, exactly as in the earlier report in #236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #236
@finmod this fixes your issues with the
device/wmmatests. I think you had other failures though, please open another issue for those.