-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of spdiagm for CUSPARSE #2458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for your implementation of spdiagm
?
Co-authored-by: Alexis Montoison <[email protected]>
Thank you @amontoison for looking at my PR. I can implement that test but I am confused about where I need to do that exactly. Can you suggest me a possible file where I can write that test? I was thinking about generic.jl or interfaces.jl. However, generic.jl looks like a place where some basic operations between matrix and vectors are tested and interfaces.jl looks like a file where linear algebra related functions are the main theme. I belive that interfaces.jl could be the correct place. But if you can shed some light on the logic behind file organization and where it is expected to implement something like this, I would appreciate it. |
For now, tests are implemented as a new test section in interfaces.jl |
The test files |
Here is the implementation of SparseArrays.spdiagm(vec)
The one(Int32) and Int32 conversions are used to reduce allocations and enhance the performance of this simple function.
Closes #1857