-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enzyme: adapt to pending version breaking update #2490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use [only downstream]
.
@maleadt okay corresponding Enzyme version has been released |
Enzyme.jl tests didn't run here because of the LLVM.jl v9.1 blacklist, so this PR was not tested. |
ah right.... okay I'll see if I can quickly fix that |
we've now released a 9.1 compatible version |
@maleadt @vchuravy CI seems to complain with a chicken and egg problem. So at this point enzyme has compat with all the latest llvm and GPUCompiler and ought be compatible with enzyme……but can’t be solved by pkg due to KA. But the KA pkg testing requirea cuda to accept the enzyme bump which means this has to have already gone in for KA to bump, and so on |
CI testing can/should use master branches. And I'm fine being the first one to merge if you have verified this locally. |
You'll have to elaborate what the problem is; I'm not familiar with Enzyme.jl (and by extension any of the code in this PR). #2472 simply added a kwarg to the kernel's call method indicating if it should call |
@maleadt okay this now passes locally on cyclops, if this can get a merge then tag |
Adapt to pending Enzymecore changes
[only downstream]
[only downstream]
No description provided.