Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUSPARSE: Fix sparse constructor with duplicate elements. #2495

Merged
merged 1 commit into from
Sep 16, 2024
Merged

CUSPARSE: Fix sparse constructor with duplicate elements. #2495

merged 1 commit into from
Sep 16, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 16, 2024

Fixes #2494

@maleadt maleadt added bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers. labels Sep 16, 2024
@maleadt maleadt mentioned this pull request Sep 16, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.06%. Comparing base (1b0bbc6) to head (091f194).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/cusparse/conversions.jl 35.71% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2495       +/-   ##
===========================================
+ Coverage   59.30%   73.06%   +13.75%     
===========================================
  Files         157      157               
  Lines       14900    14930       +30     
===========================================
+ Hits         8837    10908     +2071     
+ Misses       6063     4022     -2041

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 991e23a into master Sep 16, 2024
1 check passed
@maleadt maleadt deleted the tb/sparse_dedup branch September 16, 2024 16:17
amontoison pushed a commit to amontoison/CUDA.jl that referenced this pull request Sep 18, 2024
@maleadt @amontoison
CUSPARSE: Fix sparse constructor with duplicate elements. (JuliaGPU#2495
41a5603 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory Access error in sparse array constructor
1 participant
@maleadt