Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter alignment for dynamic parallelism. #338

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jul 30, 2020

Fixes #263

@maleadt maleadt added bugfix This gets something working again. cuda kernels Stuff about writing CUDA kernels. labels Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #338 into master will decrease coverage by 0.78%.
The diff coverage is 79.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   79.46%   78.67%   -0.79%     
==========================================
  Files         156      158       +2     
  Lines        8910     8782     -128     
==========================================
- Hits         7080     6909     -171     
- Misses       1830     1873      +43     
Impacted Files Coverage Δ
lib/cusparse/CUSPARSE.jl 100.00% <ø> (ø)
lib/cusparse/util.jl 87.50% <ø> (+27.50%) ⬆️
lib/library_types.jl 18.64% <0.00%> (-19.29%) ⬇️
test/cublas.jl 91.66% <ø> (ø)
test/cusolver.jl 100.00% <ø> (ø)
test/cusparse.jl 93.22% <ø> (ø)
deps/discovery.jl 70.39% <28.57%> (-1.61%) ⬇️
lib/cusparse/types.jl 39.47% <39.47%> (ø)
lib/cusolver/util.jl 50.00% <50.00%> (-50.00%) ⬇️
lib/cublas/util.jl 89.47% <55.55%> (-10.53%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898badb...7374ecf. Read the comment docs.

@maleadt maleadt merged commit 2c66a76 into master Jul 30, 2020
@maleadt maleadt deleted the tb/dynamic_parallelism_alignment branch July 30, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda kernels Stuff about writing CUDA kernels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange reordering of struct fields with dynamic parallelism
1 participant