Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate code from memory pools #362

Merged
merged 11 commits into from
Aug 12, 2020
Merged

Deduplicate code from memory pools #362

merged 11 commits into from
Aug 12, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 12, 2020

No description provided.

@maleadt maleadt added the cuda array Stuff about CuArray. label Aug 12, 2020
Avoids needless context look-ups.
Just have it reclaim everything periodically with interactive sessions.
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #362 into master will increase coverage by 0.09%.
The diff coverage is 73.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   79.46%   79.56%   +0.09%     
==========================================
  Files         158      159       +1     
  Lines        8782     8661     -121     
==========================================
- Hits         6979     6891      -88     
+ Misses       1803     1770      -33     
Impacted Files Coverage Δ
lib/cudadrv/memory.jl 84.97% <0.00%> (-0.45%) ⬇️
src/CUDA.jl 100.00% <ø> (ø)
src/pool.jl 72.92% <60.00%> (-4.68%) ⬇️
src/pool/none.jl 86.66% <75.00%> (+2.05%) ⬆️
src/pool/binned.jl 90.74% <90.90%> (+15.36%) ⬆️
src/debug.jl 100.00% <100.00%> (ø)
src/initialization.jl 71.87% <100.00%> (ø)
src/pool/simple.jl 90.90% <100.00%> (+1.03%) ⬆️
src/pool/split.jl 95.78% <100.00%> (+3.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9898128...77241e4. Read the comment docs.

@maleadt maleadt added the enhancement New feature or request label Aug 12, 2020
@maleadt maleadt merged commit f26dcf7 into master Aug 12, 2020
@maleadt maleadt deleted the tb/memalloc_block branch August 12, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda array Stuff about CuArray. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant