Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and update wrappers #416

Merged
merged 11 commits into from
Sep 9, 2020
Merged

Simplify and update wrappers #416

merged 11 commits into from
Sep 9, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 9, 2020

This PR does away with the pointers.json, instead making it possible to directly edit the generated headers. When wrapping new headers, the script detects new function signatures and adds those to the wrapper (not touching old ones), and moves removed ones to a deprecated file.

Together with those changes, I updated the wrappers for CUDA 11 update 1, CUTENSOR 1.2, and CUDNN 8.

cc @denizyuret, since you are working on updating our CUDNN wrappers. You can now just edit the libcudnn.jl file (but only for necessary changes, e.g., to change a Ptr to CuPtr).

@maleadt maleadt added the cuda libraries Stuff about CUDA library wrappers. label Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #416 into master will increase coverage by 0.71%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   78.83%   79.55%   +0.71%     
==========================================
  Files         170      170              
  Lines        8823     8739      -84     
==========================================
- Hits         6956     6952       -4     
+ Misses       1867     1787      -80     
Impacted Files Coverage Δ
lib/cudnn/CUDNN.jl 51.61% <ø> (ø)
lib/cusparse/CUSPARSE.jl 88.23% <ø> (ø)
res/wrap/wrap.jl 0.00% <0.00%> (ø)
lib/cublas/CUBLAS.jl 78.72% <0.00%> (-4.26%) ⬇️
lib/curand/random.jl 90.32% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4281b1b...777eb43. Read the comment docs.

@maleadt maleadt merged commit 5f41da6 into master Sep 9, 2020
@maleadt maleadt deleted the tb/wrappers branch September 9, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant