This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Add ldiv! and tests #383
Merged
Add ldiv! and tests #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
It's a bit annoying that we need to duplicate these for CuArrays since they are basically identical to the CPU version. The difference is that we use the LAPACK versions of the triangular solvers in LinearAlgebra which returns a non-zero error code for singular matrices. BLAS doesn't support error codes so this will instead cause NaN. Hence, the behavior of these methods will be slightly different from the CPU versions but I don't think that is a problem. In general, you probably want to avoid the thrown exceptions on the GPU.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the title.