This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Thread safety of memory allocator #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
force-pushed
the
tb/test_threads
branch
9 times, most recently
from
a3cc9bd
to
743f9a6
Compare
The only way to reenter is through the GC, but freeing already goes through a separate list.
Otherwise blocks can get used already between repopulating them and compacting again.
We regularly OOM here, even though that shouldn't happen with 4 threads allocating at most 12MB each. Something funny is going on; maybe related to locks in the CuArrays memory allocator?
maleadt
force-pushed
the
tb/test_threads
branch
from
743f9a6
to
b59a456
Compare
maleadt
force-pushed
the
tb/test_threads
branch
from
5f5e024
to
7d4ca14
Compare
|
Ah, finally. CI failures are some CUBLAS allocations that aren't properly guarded by |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.