Lower byval ourselves for PTX.

JuliaGPU · Oct 12, 2020 · 2b261d0 · 2b261d0
1 parent bc13183
commit 2b261d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/src/ptx.jl b/src/ptx.jl
@@ -70,13 +70,8 @@ end
 function process_kernel!(job::CompilerJob{PTXCompilerTarget}, mod::LLVM.Module, kernel::LLVM.Function)
     ctx = context(mod)
 
-    # pass all bitstypes by value
-    args = classify_arguments(job, kernel)
-    for arg in args
-        if arg.cc == BITS_REF
-            push!(parameter_attributes(kernel, arg.codegen.i), EnumAttribute("byval"))
-        end
-    end
+    # work around bad byval codegen (JuliaGPU/GPUCompiler.jl#92)
+    kernel = lower_byval(job, mod, kernel)
 
     # property annotations
     annotations = LLVM.Value[kernel]

diff --git a/test/ptx.jl b/test/ptx.jl
@@ -32,11 +32,7 @@ end
     end
 
     ir = sprint(io->ptx_code_llvm(io, kernel, Tuple{Aggregate}; kernel=true))
-    if VERSION < v"1.5.0-DEV.802"
-        @test occursin(r"@.*julia_kernel.+\(({ i64 }|\[1 x i64\]) addrspace\(\d+\)?\*.+byval", ir)
-    else
-        @test occursin(r"@.*julia_kernel.+\(({ i64 }|\[1 x i64\])\*.+byval", ir)
-    end
+    @test occursin(r"@.*julia_kernel.+\(({ i64 }|\[1 x i64\])", ir)
 end
 
 @testset "property_annotations" begin