Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate calling conventions for PTX functions and kernels. #17

Merged
merged 2 commits into from
May 15, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Apr 27, 2020

PTX_Kernel PTX_Kernel - Call to a PTX kernel. Passes all arguments in parameter space.
PTX_Device PTX_Device - Call to a PTX device function. Passes all arguments in register or parameter space.

@maleadt
Copy link
Member Author

maleadt commented Apr 27, 2020

This seems LLVM 8 (i.e. Julia 1.4) only though.

@maleadt maleadt force-pushed the tb/ptx_cc branch 2 times, most recently from ae16d82 to 92d3866 Compare May 15, 2020 06:40
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #17 into master will decrease coverage by 3.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   72.14%   68.16%   -3.98%     
==========================================
  Files          18       18              
  Lines        1156     1087      -69     
==========================================
- Hits          834      741      -93     
- Misses        322      346      +24     
Impacted Files Coverage Δ
src/ptx.jl 88.07% <100.00%> (-0.32%) ⬇️
src/gcn.jl 0.00% <0.00%> (-30.65%) ⬇️
src/interface.jl 38.46% <0.00%> (-22.26%) ⬇️
src/irgen.jl 76.53% <0.00%> (-12.00%) ⬇️
src/debug.jl 91.30% <0.00%> (-0.37%) ⬇️
src/optim.jl 98.43% <0.00%> (-0.10%) ⬇️
src/cache.jl 0.00% <0.00%> (ø)
src/mcgen.jl 100.00% <0.00%> (ø)
src/execution.jl 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46c146...e0ec595. Read the comment docs.

@maleadt
Copy link
Member Author

maleadt commented May 15, 2020

Bumping Julia to 1.4 here.

@maleadt maleadt merged commit 7fd5e2e into master May 15, 2020
@maleadt maleadt deleted the tb/ptx_cc branch May 15, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant