Disable semi-concrete interpretation, for now. #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
approved these changes
Nov 7, 2022
| @@ -243,6 +243,17 @@ Core.Compiler.method_table(interp::GPUInterpreter, sv::InferenceState) = | |||
| WorldOverlayMethodTable(interp.world) | |||
| end | |||
|
|
|||
| # semi-concrete interepretation is broken with overlays (JuliaLang/julia#47349) | |||
| @static if VERSION >= v"1.9.0-DEV.1248" | |||
There was a problem hiding this comment.
We can change this version check to something like VERSION >= v"1.9.0-DEV.1248" && VERSION <= v"1.9.0-DEV.XXXX" once we fix JuliaLang/julia#47349 in upstream.
Codecov ReportBase: 85.70% // Head: 72.50% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
===========================================
- Coverage 85.70% 72.50% -13.21%
===========================================
Files 24 24
Lines 2813 2811 -2
===========================================
- Hits 2411 2038 -373
- Misses 402 773 +371
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily disables semi-concrete IR interpretation until JuliaLang/julia#47349 is fixed.
Closes #366, #363 (cc @pxl-th).
Kudos to @aviatesk!