Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devolve responsibility in materializer #376

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Devolve responsibility in materializer #376

merged 4 commits into from
Dec 2, 2022

Conversation

vchuravy
Copy link
Member

Fixes #374 and depends on maleadt/LLVM.jl#319

Fixes EnzymeAD/Enzyme.jl#533

@maleadt
Copy link
Member

maleadt commented Nov 29, 2022

Thanks for debugging this!

@maleadt
Copy link
Member

maleadt commented Dec 1, 2022

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 73.75% // Head: 73.79% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (23e2f23) compared to base (dda3e52).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   73.75%   73.79%   +0.03%     
==========================================
  Files          24       24              
  Lines        2816     2816              
==========================================
+ Hits         2077     2078       +1     
+ Misses        739      738       -1     
Impacted Files Coverage Δ
src/irgen.jl 95.28% <100.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt
Copy link
Member

maleadt commented Dec 2, 2022

Pkg servers lagging behind again?

ERROR: LoadError: Unsatisfiable requirements detected for package LLVM [929cbde3]:
 LLVM [929cbde3] log:
 ├─possible versions are: 4.14.0 or uninstalled
 ├─restricted to versions 4.14.1-4 by GPUCompiler [61eb1bfa] — no versions left
 │ └─GPUCompiler [61eb1bfa] log:
 │   ├─possible versions are: 0.16.6 or uninstalled
 │   └─GPUCompiler [61eb1bfa] is fixed to version 0.16.6
 └─LLVM [929cbde3] is fixed to version 4.14.0

I already restarted the job this morning, to no avail.

@vchuravy
Copy link
Member Author

vchuravy commented Dec 2, 2022

The problem was the checked-in Manifest that pinned LLVM

@maleadt maleadt merged commit fbf9f01 into master Dec 2, 2022
@maleadt maleadt deleted the vc/materializer branch December 2, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants