Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIR-V: Disallow Float16/Float64 if unsupported. #429

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Apr 18, 2023

No description provided.

@maleadt maleadt added the spirv Stuff about the SPIR-V back-end. label Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: +0.27 🎉

Comparison is base (341e2e8) 86.82% compared to head (993aca8) 87.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   86.82%   87.10%   +0.27%     
==========================================
  Files          24       24              
  Lines        2930     2939       +9     
==========================================
+ Hits         2544     2560      +16     
+ Misses        386      379       -7     
Impacted Files Coverage Δ
src/metal.jl 86.16% <0.00%> (+1.54%) ⬆️
src/spirv.jl 91.13% <100.00%> (+0.47%) ⬆️
src/validation.jl 97.46% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit c9fb0be into master Apr 18, 2023
@maleadt maleadt deleted the tb/spirv_unsupported_types branch April 18, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spirv Stuff about the SPIR-V back-end.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant