Avoid synchronizing freed queues. #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
=======================================
Coverage 64.03% 64.03%
=======================================
Files 9 9
Lines 456 456
=======================================
Hits 292 292
Misses 164 164 ☔ View full report in Codecov by Sentry. |
vchuravy
reviewed
Oct 4, 2024
| finalizer(clReleaseCommandQueue, q) | ||
| finalizer(q) do _ | ||
| # this is to prevent `device_synchronize()` operating on freed queues. | ||
| # XXX: why does the WeakKeyDict contain freed objects? |
There was a problem hiding this comment.
Order of finalizers? E.g. the second finalizer that removes q from queues hasn't run yet?
There was a problem hiding this comment.
There was a problem hiding this comment.
That, or maybe the objects are collected as part of a single collection cycle? In any case, kind-of surprising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.