-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial port commit #2
Conversation
Note that tests are currently failing because I'm waiting for this PR to be merged into edit: I actually just need a patch version bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few suggestions and doubts. Thanks!
Co-Authored-By: Sharan Yalburgi <[email protected]>
Co-Authored-By: Sharan Yalburgi <[email protected]>
Co-Authored-By: Sharan Yalburgi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 7
Lines ? 122
Branches ? 0
==========================================
Hits ? 122
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
@sharanry reading for another round of review. Let me know what you think. |
Co-Authored-By: David Widmann <[email protected]>
Co-Authored-By: Sharan Yalburgi <[email protected]>
Co-Authored-By: Sharan Yalburgi <[email protected]>
Thanks for the extensive reviewing @sharanry . Will merge once tests pass. |
This ports a lot of initial work over from Stheno.jl. There's still some stuff to do, but intended use should be clear from the tests.
Left to do:
Write some initial docsedit: the readme will suffice for this PR.
edit2: added standardised testing for the AbstractGP interface to make it easy to check that it's been implemented fully and self-consistently.