Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial port commit #2

Merged
merged 26 commits into from
Apr 28, 2020
Merged

Initial port commit #2

merged 26 commits into from
Apr 28, 2020

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Apr 22, 2020

This ports a lot of initial work over from Stheno.jl. There's still some stuff to do, but intended use should be clear from the tests.

Left to do:

  • Implement approximate posterior type to handle VFE / DTC appropriately.
  • Reintroduce doctests + fix any errors.
  • Specify the AbstractGP interface in abstract_gp.jl + document.
  • Write a readme
  • Write some initial docs

edit: the readme will suffice for this PR.

edit2: added standardised testing for the AbstractGP interface to make it easy to check that it's been implemented fully and self-consistently.

@willtebbutt
Copy link
Member Author

willtebbutt commented Apr 22, 2020

Note that tests are currently failing because I'm waiting for this PR to be merged into KernelFunctions, and at least a new patch version to be released.

edit: I actually just need a patch version bump.

Copy link
Contributor

@sharanry sharanry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few suggestions and doubts. Thanks!

src/AbstractGPs.jl Outdated Show resolved Hide resolved
src/gp/gp.jl Outdated Show resolved Hide resolved
src/gp/gp.jl Outdated Show resolved Hide resolved
src/abstract_gp/finite_gp.jl Show resolved Hide resolved
src/gp/gp.jl Outdated Show resolved Hide resolved
src/abstract_gp/finite_gp.jl Outdated Show resolved Hide resolved
willtebbutt and others added 4 commits April 25, 2020 19:07
Co-Authored-By: Sharan Yalburgi <[email protected]>
Co-Authored-By: Sharan Yalburgi <[email protected]>
Co-Authored-By: Sharan Yalburgi <[email protected]>
@codecov-io
Copy link

codecov-io commented Apr 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4d61a75). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master        #2   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         7           
  Lines             ?       122           
  Branches          ?         0           
==========================================
  Hits              ?       122           
  Misses            ?         0           
  Partials          ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d61a75...cc553c8. Read the comment docs.

@willtebbutt willtebbutt changed the title [WIP] Initial port commit Initial port commit Apr 26, 2020
@willtebbutt
Copy link
Member Author

@sharanry reading for another round of review. Let me know what you think.

.travis.yml Outdated Show resolved Hide resolved
Co-Authored-By: David Widmann <[email protected]>
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
src/abstract_gp/finite_gp.jl Show resolved Hide resolved
src/abstract_gp/finite_gp.jl Outdated Show resolved Hide resolved
src/abstract_gp/finite_gp.jl Outdated Show resolved Hide resolved
src/posterior_gp/posterior_gp.jl Show resolved Hide resolved
@willtebbutt
Copy link
Member Author

Thanks for the extensive reviewing @sharanry . Will merge once tests pass.

@willtebbutt willtebbutt merged commit 1bf8fb3 into master Apr 28, 2020
@willtebbutt willtebbutt deleted the wct/design-api branch May 3, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants