Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for LogDensityProblems to 0.11 for package regression-1d, (keep existing compat) #206

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the LogDensityProblems package from 0.10 to 0.10, 0.11 for package regression-1d.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #206 (9c4cdbd) into master (b5a53b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          10       10           
  Lines         356      356           
=======================================
  Hits          349      349           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a53b5...9c4cdbd. Read the comment docs.

@st--

This comment has been minimized.

@devmotion
Copy link
Member

devmotion commented Oct 14, 2021

@cscherrer
Copy link
Contributor

Thanks @devmotion for letting me know! I didn't know this had a dependency on MeasureTheory. We should add it to the Breakage CI.

It might be related to the Soss issue, I'll check into that.

@devmotion
Copy link
Member

I didn't know this had a dependency on MeasureTheory.

AbstractGPs you mean? It doesn't depend on MeasureTheory, we just run tests with GPs inside of Turing and Soss models to check the use of AbstractGPs with different PPLs in a separate test environment, outside of the regular CI. We separated these tests to avoid that compat issues in Turing or Soss break our CI tests, and these tests are allowed to fail (so there's no pressure from our side here).

@devmotion
Copy link
Member

@cscherrer I just reran the tests and they still fail, even with the latest Soss release. So unfortunately it seems the problem was not completely identical to the Soss issue that you fixed in 0.20.8.

@cscherrer
Copy link
Contributor

Thanks @devmotion . I think the next step is to get a MWE (MBE?) into the Soss tests, that will make it easier to fix and avoid re-breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants