Remove Manifests from repo #99
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## tgf/remove_manifests #99 +/- ##
=======================================================
Coverage ? 95.78%
=======================================================
Files ? 4
Lines ? 285
Branches ? 0
=======================================================
Hits ? 273
Misses ? 12
Partials ? 0 Continue to review full report at Codecov.
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| using Literate: Literate | ||
|
|
||
| const MANIFEST_OUT = "$(EXAMPLE).Manifest.toml" |
There was a problem hiding this comment.
Why not save it as joinpath(EXAMPLE, "Manifest.toml") ?
There was a problem hiding this comment.
because within the preprocess you want to use the filename only, not the full path to the examples/ source directory
There was a problem hiding this comment.
Here EXAMPLE is just a-regression for example. And then the loading line can just be [Here is the Manifest](./Manifest.toml)
…mples (#97) * Remove Manifest.toml and append package version at the end of the examples * Update docs/literate.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix Regex * Addressed some comments * Update docs/literate.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update docs/literate.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Trying to put some HTML * Format * Add computer info as well * Missing using * Missing hashtags * Change order Computer info and Manifest * Remove Manifests from repo (#99) * make literate.jl copy Manifests into rendered docs * remove examples Manifest.toml * Update docs/literate.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Théo Galy-Fajou <[email protected]> * Removed the Manifest preview (one can download it anyway) * Formatting * Apply suggestions from code review Co-authored-by: st-- <[email protected]> * Remove docs/Manifest.toml Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: st-- <[email protected]>
And copy Manifest.toml from instantiation into rendered docs