Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import marginals #173

Merged
merged 3 commits into from
Apr 10, 2021
Merged

Import marginals #173

merged 3 commits into from
Apr 10, 2021

Conversation

devmotion
Copy link
Member

I guess you actually want to import AbstractGPs.marginals or qualify the definition in

marginals(f::SparseFiniteGP) = marginals(f.fobs)
. I assume this causes the problem reported in https://discourse.julialang.org/t/stheno-marginals/58943.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@willtebbutt willtebbutt merged commit e348446 into master Apr 10, 2021
@devmotion devmotion deleted the dw/marginals branch April 10, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants