Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop doing sparse stuff in this package #213

Merged
merged 9 commits into from
Aug 26, 2021

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Aug 26, 2021

AbstratGPs.jl does it, so Stheno.jl shouldn't also. It's unecessary maintenance.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #213 (c3e94fb) into master (577fce7) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head c3e94fb differs from pull request most recent head 1d7e652. Consider uploading reports for the commit 1d7e652 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   86.65%   86.42%   -0.23%     
==========================================
  Files          17       17              
  Lines         442      442              
==========================================
- Hits          383      382       -1     
- Misses         59       60       +1     
Impacted Files Coverage Δ
src/composite/cross.jl 97.36% <ø> (ø)
src/gaussian_process_probabilistic_programme.jl 100.00% <ø> (ø)
src/sparse_finite_gp.jl 93.33% <100.00%> (ø)
src/util/zygote_rules.jl 92.30% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577fce7...1d7e652. Read the comment docs.

@willtebbutt willtebbutt merged commit 6818fe4 into master Aug 26, 2021
@willtebbutt willtebbutt deleted the wct/depend-on-abstractgps-sparse-stuff branch August 26, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants