Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AD #244

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Fix AD #244

merged 4 commits into from
Jun 14, 2023

Conversation

willtebbutt
Copy link
Member

No description provided.

@willtebbutt
Copy link
Member Author

@martincornejo apologies for the delay on this. You were right about the mean_vector stuff, but it turns out we just need to opt out of some rrules in order to get this stuff to work.

Do you mind if we go with this approach rather than yours?

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bd15654) 100.00% compared to head (7f28e95) 100.00%.

❗ Current head 7f28e95 differs from pull request most recent head 4083ed0. Consider uploading reports for the commit 4083ed0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        12    +1     
  Lines          285       287    +2     
=========================================
+ Hits           285       287    +2     
Impacted Files Coverage Δ
src/Stheno.jl 100.00% <ø> (ø)
src/affine_transformations/addition.jl 100.00% <ø> (ø)
src/affine_transformations/compose.jl 100.00% <ø> (ø)
src/affine_transformations/cross.jl 100.00% <ø> (ø)
src/gp/atomic_gp.jl 100.00% <ø> (ø)
src/gp/derived_gp.jl 100.00% <ø> (ø)
src/affine_transformations/product.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martincornejo
Copy link

Perfect! I've been working with my fix in the meanwhile, but this solution is much better. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants