Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to docs for polygonize #142

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

asinghvi17
Copy link
Member

No description provided.

@asinghvi17 asinghvi17 requested a review from rafaqz May 14, 2024 17:33
@rafaqz
Copy link
Member

rafaqz commented May 15, 2024

Maybe wait for the other PR

@rafaqz rafaqz merged commit 0be82ff into fix_polygonize May 15, 2024
4 checks passed
@rafaqz rafaqz deleted the asinghvi17-patch-2 branch May 15, 2024 20:17
rafaqz added a commit that referenced this pull request May 16, 2024
* start improving and testing bools

* add turf boolean tests

* more fixes

* fix polygonize

* fix polygonize and tweak performance

* optimise geometry processes with extent checks

* cleanup

* more cleanup

* handle over_allow and cross_allow

* only simple optimisations for now

* clean up example

* fix methods

* add multiple value handling

* dict

* faster with dict

* update disjoint optimisation logic

* get size down to an 8 multiple

* remove bools.jl

* cleanup

* test and allow multi value functions

* more tests

* fix extents for performance

* fix docs

* as/polygonize_docs (#142)

* Try to fix Literate not detecting the text properly

* Add testing packages to extras

* Return edge vectors with the same axis semantics as `axes(A)`

* Propagate CRS

* Propagate extend to returned MultiPolygon for the Bool case

* Add exotic array tests for polygonize

With the changes from the last commit, even Rasters work with roundtripped CRS.  The only thing remaining to be done is to figure out how to generate edge vectors for interval sampling, which would probably be an extension on Rasters in GeometryOps, since we're overriding an internal GO method.

* Remove unnecessary `crs` passthrough to temporary geometries

Co-authored-by: Rafael Schouten <[email protected]>

* Use mapreduce instead of reduce for extent unioning

Co-authored-by: Rafael Schouten <[email protected]>

* Add extent and CRS to features and featurecollections in polygonize

* dont add nodes in straight lines

* clean up and dict performance tweaks

---------

Co-authored-by: Anshul Singhvi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants