Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the new NetCDF_jll; require julia 1.3 #123

Merged
merged 5 commits into from
Nov 30, 2020
Merged

use the new NetCDF_jll; require julia 1.3 #123

merged 5 commits into from
Nov 30, 2020

Conversation

visr
Copy link
Member

@visr visr commented Jun 1, 2020

I wanted to give the new NetCDF_jll from JuliaPackaging/Yggdrasil#1090 a test run.

Since this relies on Artifacts being available it needs julia 1.3 minimum and therefore a minor version bump, to 0.11.

https://github.com/JuliaBinaryWrappers/NetCDF_jll.jl

Also see Alexander-Barth/NCDatasets.jl#88

@meggart
Copy link
Member

meggart commented Aug 4, 2020

Thanks a lot for trying this, indeed getting this fixed would be huge. I just returned from a longer break, but it looks like this JuliaPackaging/Yggdrasil#1112 would need to get resolved first to make this PR work. I don't know how I could contribute right now....

@visr
Copy link
Member Author

visr commented Aug 4, 2020

Welcome back! That is indeed the right issue.

Longer term we can hopefully fix JuliaPackaging/Yggdrasil#567 but that will need work on the HDF5 build script, see also https://forum.hdfgroup.org/t/cross-compiling-for-windows/6735.

@musm
Copy link

musm commented Sep 10, 2020

I'm curious why HDF5.jl is holding this up?

@musm
Copy link

musm commented Sep 10, 2020

Is the exact HDF5 version important here? Apparently I've had two user report NetCDF is clashing with MATLAB.jl and I can't really do anything about it unfortunately.

@visr
Copy link
Member Author

visr commented Sep 26, 2020

@musm there is more discussion here: Alexander-Barth/NCDatasets.jl#88, about what is holding this up (Warning! ***HDF5 library version mismatched error***).

The exact HDF5 version is not important, what is important that the headers and binaries are mismatched right now.

@visr visr mentioned this pull request Oct 22, 2020
@musm
Copy link

musm commented Nov 16, 2020

If anyone here wants to help with the hdf5 cross-compilation mission we need the output from https://github.com/musm/hdf5-build-output for various target systems

I wanted to give the new NetCDF_jll from JuliaPackaging/Yggdrasil#1090 a test run.

Since this relies on Artifacts being available it needs julia 1.3 minimum and therefore a minor version bump, to 0.11.

https://github.com/JuliaBinaryWrappers/NetCDF_jll.jl

Also see Alexander-Barth/NCDatasets.jl#88
This adds NetCDF itself as a dependency, just like is done in PkgTemplates. That means Conda is still a dependency for now until we tag a new release.
With prettyurls set to false for local builds, such that you don't need to run a local server to click around.
@visr visr requested a review from meggart November 23, 2020 19:42
Copy link
Member

@meggart meggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge! Very good to see the Conda dependency go. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants