Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont use macro for aliases and introduce more variants (Float64 -> d, UInt -> ui) #214

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Feb 8, 2024

This PR makes all aliases recognizable by the linter and adds missing ones.

@SimonDanisch SimonDanisch changed the title dont use maccro for aliases and introduce more variants (Float64 -> d, UInt -> ui) dont use macro for aliases and introduce more variants (Float64 -> d, UInt -> ui) Feb 8, 2024
@SimonDanisch
Copy link
Member Author

Weird, this makes the texture atlas hashing tests fail in Makie...
Not sure how, since this should only change aliases - and looks like all involved aliases seem to work correctly.
Will need some further investigation.

Meanwhile, we should think about adding even more aliases here for the other primitives?
Or also for e.g. Int32 etc? Although I think that goes a bit too far, but then again it would make it more consistent.

@putianyi889
Copy link
Contributor

As for the docstrings, it's now possible to generate one docstring for each alias. Then there should be a section on doc that clarifies the meaning of the suffixes.

@SimonDanisch SimonDanisch merged commit 9550977 into master Apr 26, 2024
8 checks passed
@SimonDanisch SimonDanisch deleted the sd/aliases branch April 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants