Modernize #33
Merged
Modernize #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 87.22% 87.30% +0.08%
==========================================
Files 6 6
Lines 368 394 +26
==========================================
+ Hits 321 344 +23
- Misses 47 50 +3 ☔ View full report in Codecov by Sentry. |
|
Ok, @SimonDanisch seems we ran into JuliaLang/julia#51996 . As for the docs, it's Documenter v1, I will try to fix this. |
Seems to fix problem on 1.11 and works for earlier versions
* set warnonly=true as the missing docstrings are not relevant for user API.
|
IMHO this is ready to go - no resources in the moment to increase coverage. |
sjkelly
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting, fix named
using, remove some superfluous files from stl dir