Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis - add osx, remove 0.7 add 1.1 #86

Merged
merged 1 commit into from
May 4, 2019

Conversation

IanButterworth
Copy link
Contributor

@IanButterworth IanButterworth commented May 1, 2019

Attempting to root out JuliaImages/ImageView.jl#175

@IanButterworth
Copy link
Contributor Author

Now that osx is added to travis, its seems like my issues from JuliaImages/ImageView.jl#175 are replicated

@IanButterworth
Copy link
Contributor Author

IanButterworth commented May 1, 2019

These tests are failing with both width and height returned as 1:

using GtkReactive, Gtk.ShortNames, Graphics, Test

c = canvas(208, 207)
win = Window(c)
Gtk.showall(win)
sleep(0.1)
@test Graphics.width(c) == 208
@test Graphics.height(c) == 207

@timholy any ideas?!

@timholy
Copy link
Member

timholy commented May 2, 2019

Interesting, and obviously unfortunate. Is it "just" a test failure or does it fail in real-world practice? Do either of the following demos work for you:

@IanButterworth
Copy link
Contributor Author

Both examples result in blank windows, with no errors.
Screen Shot 2019-05-01 at 11 08 24 PM

It would be good if another MacOS user could locally test this, and if theirs works, figure out what's different about my setup

@timholy
Copy link
Member

timholy commented May 2, 2019

OK, this is probably a Gtk or Cairo error. Do any non-canvas aspects of Gtk work for you?

@IanButterworth
Copy link
Contributor Author

Cairo seems ok.. tests pass and this renders the png properly
https://github.com/JuliaGraphics/Cairo.jl/blob/master/samples/sample_arc.jl

Gtk tests pass, but the windows during the tests are blank, as is the window in the basic examples
http://juliagraphics.github.io/Gtk.jl/latest/manual/gettingStarted.html

I just removed the full Gtk package dir and rebuilt and have the same issue

@timholy
Copy link
Member

timholy commented May 2, 2019

OK, it seems this is a Gtk issue. I'll close this and the one in ImageView, and perhaps you can report issues there.

This adds fuel to the fire of replacing Gtk with something else. But that is a lot of work so I am not there yet.

@IanButterworth
Copy link
Contributor Author

Ok. I've repurposed JuliaGraphics/Gtk.jl#414

Is this PR worth merging? Only adjust travis to cover osx and v1.1

@timholy
Copy link
Member

timholy commented May 4, 2019

Indeed. Letting osx fail will remind me that we need to fix this sometime. Thanks!

@timholy timholy merged commit a698eb8 into JuliaGizmos:master May 4, 2019
@timholy
Copy link
Member

timholy commented May 4, 2019

Ah shoot, I should have asked you to change the bounds in Project.toml (principle: don't claim to support 0.7 unless you're testing it). But I will fix it.

@IanButterworth
Copy link
Contributor Author

Ah, missed that. Apologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants