temporary: patch segfault on mac #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
am I right that this fixes the OSX issues? |
|
This should not have been merged in this state. The minimum supported Julia version needs to be raised since this uses syntax that does not work on 0.6. Or Compat would need to be used for it, and testing put back for 0.6. |
|
@tkelman: drop 0.6 support. I think it is much more problematic that currently Cairo, Gtk, ... are not working in Mac than to have the current releases working in Julia 0.6, which only a fraction of people is using. When the METADATA <-> Registry sync is removed (very soon!) then it will be difficult to maintain 0.6 compat anyway. |
|
@tknopp JuliaLang/Compat.jl#651 will happen anyway |
Closed
|
Dropping 0.6 support is fine (this PR didn't do that - it uses syntax that wouldn't work there but still claims to support it in REQUIRE), but dropping testing of a version without changing the minimum supported version is not a good idea. |
|
Depends whether you plan on tagging any additional versions in METADATA that do support 0.6. If not, then the REQUIRE file should be replaced with a toml version, which should include a minimum supported julia version of 0.7 or higher |
|
hi all, |
|
@floswald do you have system-wide hombrew installed? you may still need to run |
|
tried that: |
|
@floswald it's quite strange... I cannot reproduce with a new julia depot (essentially a new .julia directory): in bash terminal outside julia, |
|
|
@floswald run |
|
here is the seond time: |
|
in bash should be this PR fixes the segfault caused by glib no longer supporting |
|
sorry, my bad. |
|
@floswald since the patch is not released, you should use |
|
of course! sorry. unfortunately get the same thing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussed here, and also on upstream glib here, using
dlopen/dlcloseis not supported by glib, but is used by BinDeps; suggested in JuliaPackaging/BinDeps.jl#397 and verified byprint(getpid()), the build process is run in another pid, therefore not usingdlclosemay be ok, patched with the new build.jl: only patch for macos and only patch the current version of BinDeps (occursin("ZEval",pathof(BinDeps)))julia: 0.6 removed in .travis.yml since pathof is not available there, feel free to disregard
temporary until maybe #229 is finished?