Remove the shackles of ImageMagick #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImageMagick has largely been supplanted by ImageIO. I also thought I'd see what you thought about avoiding being "opinionated" about which specific IO packages are best, so I moved such dependencies to [extras]. But we could move such dependencies back to [deps] if you're worried about providing an out-of-box experience that "just works" without the user having to choose specific IO package(s). xrefs: - JuliaIO/PNGFiles.jl#45 - JuliaIO/FileIO.jl#352
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 71.34% 71.34%
=======================================
Files 32 32
Lines 5496 5496
=======================================
Hits 3921 3921
Misses 1575 1575 Continue to review full report at Codecov.
|
|
That's great! Thanks Tim. Let's do it and see what happens... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageMagick has largely been supplanted by ImageIO.
I also thought I'd see what you thought about avoiding being
"opinionated" about which specific IO packages are best,
so I moved such dependencies to [extras]. But we could move
such dependencies back to [deps] if you're worried about
providing an out-of-box experience that "just works" without
the user having to choose specific IO package(s).
xrefs: