Fix setheaderdata! in JuliaItemModel

JuliaGraphics · Jul 11, 2024 · de00112 · de00112
1 parent e5fa1ec
commit de00112
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/itemmodel.jl b/src/itemmodel.jl
@@ -104,9 +104,9 @@ function defaultsetheaderdata!(data, row_or_col, orientation, value, role)
   return
 end
 
-function setheaderdata!(itemmodel::JuliaItemModel, row_or_col, orientation, value, role)
+@cxxdereference function setheaderdata!(itemmodel::JuliaItemModel, row_or_col, orientation, value, role)
   m = get_julia_data(itemmodel)
-  m.setheaderdata(m.values[], row_or_col, orientation[], value, role)
+  m.setheaderdata(m.values[], row_or_col, orientation[], QML.value(value), role)
   emit_header_data_changed(itemmodel, orientation[], row_or_col, row_or_col)
 end
 

diff --git a/test/containers.jl b/test/containers.jl
@@ -52,5 +52,5 @@ let numbers = [1,2,3,4], model = JuliaItemModel(numbers)
   @test QML.setdata!(model, QVariant(5), QML.EditRole, 3, 1)
   @test QML.value(QML.data(modeldata, QML.DisplayRole,3,1)) == "5"
   @test QML.value(QML.headerdata(modeldata, 2, QML.Vertical, QML.DisplayRole)) == 2
-  @test_logs (:warn,"Setting header data is not supported in this model") QML.setheaderdata!(model, 1, QML.Vertical, QML.EditRole, "One")
+  @test_logs (:warn,"Setting header data is not supported in this model") QML.setheaderdata!(model, 1, QML.Vertical, QVariant("One"), QML.EditRole)
 end