Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6 #155

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Qt6 #155

merged 1 commit into from
Feb 20, 2023

Conversation

PallHaraldsson
Copy link
Contributor

[skip ci]

[skip ci]
@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Jan 28, 2023

It seems to be Qt6 already according to merged PR (for Qt6Base_jll), on main branch at least. I do not see the Qt6 branch (I guess deleted), but likely you need to tag a new version. I noticed LGPL->MIT issue, and since this is just a doc change, you don't need my permission, or at least you have it just in case...

Also don't forget to update under About: "Build Qt5 QML interfaces for Julia programs."

I think Qt6 supports everything that Qt5 does (more or less, possibly something unimportant deprecated and removed), so it and this package should be strictly better. For your package however, maybe the transition dropped some code, so you don't need permission from all for MIT, at least for Qt6? Though you might want permission for older versions too.

When you choose to merge (and for MIT change) it would be good for info at https://juliahub.com/ui/Packages/QML/JLkMo/0.7.1?page=0 to also be updated. It seems Juliahub sometimes shows outdated cached info, at least for dependencies, so you may need to ask them to fix, or monitor after. I'm not sure if anything ever gets automatically updated there.

@barche barche merged commit 5a32673 into JuliaGraphics:main Feb 20, 2023
@PallHaraldsson PallHaraldsson deleted the patch-1 branch February 20, 2023 10:10
@PallHaraldsson
Copy link
Contributor Author

Hi, I don't think Qt6 is mentioned in the docs, and I overlooked:

Module for building Qt5 QML graphical user interfaces for Julia programs. [..]

julia> using Qt5QuickControls_jll

I assume that using no longer applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants