Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Julia 1.3 from Travis CI configuration #58

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

notZaki
Copy link
Member

@notZaki notZaki commented Aug 11, 2020

Julia 1.3 doesn't need to be in the tests.
It was added when Julia 1.3 was the latest version and I didn't know that the version '1' would always use the latest release.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files           1        1           
  Lines         312      312           
=======================================
  Hits          274      274           
  Misses         38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd50f23...9db16da. Read the comment docs.

@notZaki
Copy link
Member Author

notZaki commented Aug 11, 2020

A more aggressive approach could be to remove the latest release, i.e. '1', from the tests as well. In theory, the builds on 1.0 and nightly should encompass everything in between.

@DilumAluthge
Copy link
Member

A more aggressive approach could be to remove the latest release, i.e. '1', from the tests as well. In theory, the builds on 1.0 and nightly should encompass everything in between.

In theory.... sometimes nightly does weird stuff though.

@DilumAluthge
Copy link
Member

One thing we could consider would be switching from Travis to GitHub Actions. Usually GH Actions is much faster.

If you're interested, let me know - I'm happy to make a PR to set up GH Actions for CI testing on this repo.

@notZaki
Copy link
Member Author

notZaki commented Aug 11, 2020

That sounds great!
I'm curious about GH Actions too, so seeing it applied in a setup I'm previously familiar with would be a useful learning opportunity for me.

@DilumAluthge DilumAluthge changed the title Remove Julia 1.3 from tests Remove Julia 1.3 from Travis CI configuration Aug 11, 2020
@DilumAluthge DilumAluthge merged commit 5f12f26 into JuliaHealth:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants