Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI Observables management #210

Merged
merged 43 commits into from
Nov 14, 2023
Merged

Improve UI Observables management #210

merged 43 commits into from
Nov 14, 2023

Conversation

beorostica
Copy link
Contributor

This is meant to solve UI issues #66 and #198 and organize the code related to the UI.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #210 (16743c4) into master (be764be) will increase coverage by 0.05%.
The diff coverage is 92.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   91.48%   91.53%   +0.05%     
==========================================
  Files          40       31       -9     
  Lines        2207     2256      +49     
==========================================
+ Hits         2019     2065      +46     
- Misses        188      191       +3     
Flag Coverage Δ
core 90.30% <88.79%> (+0.02%) ⬆️
komamri 94.05% <92.94%> (+0.11%) ⬆️
plots 93.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
KomaMRICore/src/datatypes/Phantom.jl 94.02% <100.00%> (ø)
KomaMRICore/src/datatypes/sequence/ADC.jl 94.87% <ø> (ø)
KomaMRICore/src/datatypes/sequence/Delay.jl 100.00% <ø> (ø)
KomaMRICore/src/datatypes/sequence/Grad.jl 94.82% <100.00%> (ø)
KomaMRICore/src/datatypes/sequence/RF.jl 88.88% <ø> (ø)
...ICore/src/datatypes/simulation/DiscreteSequence.jl 100.00% <100.00%> (ø)
KomaMRICore/src/io/ISMRMRD.jl 98.00% <100.00%> (ø)
KomaMRICore/src/io/JEMRIS.jl 100.00% <100.00%> (ø)
KomaMRICore/src/io/MRiLab.jl 100.00% <100.00%> (ø)
KomaMRICore/src/io/Pulseq.jl 84.12% <100.00%> (ø)
... and 8 more

KomaMRICore/src/datatypes/Phantom.jl Outdated Show resolved Hide resolved
KomaMRICore/src/datatypes/Scanner.jl Outdated Show resolved Hide resolved
KomaMRICore/src/datatypes/Sequence.jl Outdated Show resolved Hide resolved
KomaMRICore/src/datatypes/sequence/ADC.jl Outdated Show resolved Hide resolved
KomaMRICore/src/datatypes/Sequence.jl Outdated Show resolved Hide resolved
KomaMRICore/src/datatypes/sequence/RF.jl Outdated Show resolved Hide resolved
KomaMRICore/src/datatypes/simulation/DiscreteSequence.jl Outdated Show resolved Hide resolved
KomaMRICore/src/datatypes/simulation/DiscreteSequence.jl Outdated Show resolved Hide resolved
KomaMRICore/src/io/ISMRMRD.jl Outdated Show resolved Hide resolved
KomaMRICore/src/io/Pulseq.jl Outdated Show resolved Hide resolved
@cncastillo cncastillo merged commit 90d345e into master Nov 14, 2023
15 of 16 checks passed
@cncastillo cncastillo deleted the observables branch November 14, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants