Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KomaMRIIO subpackage #231

Merged
merged 41 commits into from
Dec 1, 2023
Merged

KomaMRIIO subpackage #231

merged 41 commits into from
Dec 1, 2023

Conversation

beorostica
Copy link
Contributor

@beorostica beorostica commented Nov 28, 2023 •
edited by cncastillo
Loading

@beorostica beorostica mentioned this pull request Nov 28, 2023
Closed
cncastillo
cncastillo reviewed Nov 28, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #231 (435f8f8) into master (8e6ac21) will decrease coverage by 1.36%.
The diff coverage is 58.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   91.60%   90.24%   -1.36%     
==========================================
  Files          31       33       +2     
  Lines        2252     2287      +35     
==========================================
+ Hits         2063     2064       +1     
- Misses        189      223      +34
Flag Coverage Δ
core 89.00% <56.79%> (-1.41%) ⬇️
io 86.44% <55.55%> (?)
komamri 94.09% <100.00%> (+0.02%) ⬆️
plots 93.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
KomaMRICore/src/KomaMRICore.jl 100.00% <ø> (ø)
KomaMRIIO/src/KomaMRIIO.jl 100.00% <100.00%> (ø)
KomaMRIIO/src/Phantom/JEMRIS.jl 100.00% <ø> (ø)
KomaMRIIO/src/Phantom/MRiLab.jl 100.00% <ø> (ø)
KomaMRIIO/src/RawAcquisitionData/WriteRawData.jl 100.00% <100.00%> (ø)
src/KomaMRI.jl 100.00% <ø> (ø)
src/KomaUI.jl 99.26% <100.00%> (+<0.01%) ⬆️
src/ui/ExportUIFunctions.jl 89.00% <100.00%> (+0.05%) ⬆️
KomaMRICore/src/simulation/SimulatorCore.jl 81.05% <0.00%> (ø)
KomaMRIIO/src/Sequence/Pulseq.jl 84.12% <33.33%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

@cncastillo
Copy link
Member

cncastillo commented Nov 28, 2023 •
edited by beorostica
Loading

I commented with some things that will need to change. You are also missing changes in the:

  • README.md and -> f425357
  • CodeCov (tags, and the actual coverage). -> bb696e9

@cncastillo
Copy link
Member

cncastillo commented Nov 28, 2023 •
edited by beorostica
Loading

Also the UI is missing KomaIO's package version:

  • both for the UI and -> f65c8fc
  • the print that it does while openning. -> f65c8fc

@cncastillo cncastillo mentioned this pull request Nov 28, 2023
Open
@beorostica beorostica self-assigned this Nov 29, 2023
cncastillo
cncastillo approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@cncastillo cncastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine for merging to master but we need to create a high priorty issue that fixes some of the circular dependancies between core and io in their tests.

@beorostica Add an issue about this please.

@cncastillo cncastillo merged commit 879894a into master Dec 1, 2023
13 checks passed
@cncastillo cncastillo deleted the komaio branch December 1, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cncastillo cncastillo cncastillo approved these changes

Assignees

@beorostica beorostica

Labels
1) high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beorostica @cncastillo