Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect gradient interpretation when waveforms do not end in zero #321

Merged
merged 62 commits into from
Apr 8, 2024
Merged

Incorrect gradient interpretation when waveforms do not end in zero #321

merged 62 commits into from
Apr 8, 2024

Commits on Mar 11, 2024

  1. Avoid abrupt changes between block gradients

    @beorostica
    beorostica committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    cd844bc View commit details
    Browse the repository at this point in the history

  2. Remove delay for RF when no RF is present during pulseq reading

    @beorostica
    beorostica committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c0d5589 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Add condition for no RF or ADC when reading pulseq file

    @beorostica
    beorostica committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ce9e97a View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Temporal read tests: comparison between koma and pulseq

    @beorostica
    beorostica committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a4b1d1e View commit details
    Browse the repository at this point in the history

  2. Move folder for temporal read tests

    @beorostica
    beorostica committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    929bf5e View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Temporal updates for reading pulseq files

    @beorostica
    beorostica committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    cf572ca View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Fix bug when running new read comparison tests

    @beorostica
    beorostica committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    aefa3e0 View commit details
    Browse the repository at this point in the history

  2. Sort tests when comparing pulseq and koma readings

    @beorostica
    beorostica committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ba56717 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'master' into zero-concat

    @beorostica
    beorostica committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    17899c1 View commit details
    Browse the repository at this point in the history

  2. Temporal local changes: add first last pulseq points for grads

    @beorostica
    beorostica committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7ed7c4b View commit details
    Browse the repository at this point in the history

  3. Add logic to consider first and last points for gradients

    @beorostica
    beorostica committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c95e309 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Add temporal time_shape_id property to Grad struct for debuging

    @beorostica
    beorostica committed Mar 27, 2024
    1 Configuration menu
    Copy the full SHA
    83da9a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into zero-concat

    @cncastillo
    cncastillo authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f2e3b05 View commit details
    Browse the repository at this point in the history

  3. Remove temporal time_shape_id property from Grad struct

    @beorostica
    beorostica committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ddc6d93 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Add temporal test for comparing read RF

    @beorostica
    beorostica committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    d3cc103 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into zero-concat

    @cncastillo
    cncastillo authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    591130c View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Add tests for spiral GRE and EPI when reading pulseq

    @beorostica
    beorostica committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    84043cf View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Add some changes for first/last points in gradients

    @beorostica
    beorostica committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5ed4362 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'zero-concat' of github.com:cncastillo/KomaMRI.jl into z… 

    …ero-concat
    @beorostica
    beorostica committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ed9def0 View commit details
    Browse the repository at this point in the history

  3. Update KomaMRIFiles/src/Sequence/Pulseq.jl 

    Co-authored-by: Carlos Castillo Passi <[email protected]>
    @beorostica @cncastillo
    beorostica and cncastillo authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    8d680e4 View commit details
    Browse the repository at this point in the history

  4. Update KomaMRIFiles/src/Sequence/Pulseq.jl 

    Co-authored-by: Carlos Castillo Passi <[email protected]>
    @beorostica @cncastillo
    beorostica and cncastillo authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    aefbc9a View commit details
    Browse the repository at this point in the history

  5. Remove dummy conditional for pulseq read_ADC

    @beorostica
    beorostica committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5baa0a0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'zero-concat' of github.com:cncastillo/KomaMRI.jl into z… 

    …ero-concat
    @beorostica
    beorostica committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d96120e View commit details
    Browse the repository at this point in the history

  7. Update KomaMRIFiles/src/Sequence/Pulseq.jl 

    Co-authored-by: Carlos Castillo Passi <[email protected]>
    @beorostica @cncastillo
    beorostica and cncastillo authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    435d447 View commit details
    Browse the repository at this point in the history

  8. Add some tabs to Grad struct

    @beorostica
    beorostica committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e8d4d85 View commit details
    Browse the repository at this point in the history

  9. Create fix_first_last_grads! function

    @beorostica
    beorostica committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1a989f5 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into zero-concat

    @cncastillo
    cncastillo authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5c97fcb View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Change RF interpretation from ZOH -> linear-interpolation and read th… 

    …e last value from RF pulseq
    @beorostica
    beorostica committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8dfb9d2 View commit details
    Browse the repository at this point in the history

  2. Add if: !cancelled() to CI

    @beorostica
    beorostica committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b55c84f View commit details
    Browse the repository at this point in the history

  3. Use @testitem for pulseq reading comparison

    @beorostica
    beorostica committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e437fca View commit details
    Browse the repository at this point in the history

  4. Proper RF Δf handling

    @cncastillo
    cncastillo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c9b6556 View commit details
    Browse the repository at this point in the history

  5. Fixed Δf in get_theo_A

    @cncastillo
    cncastillo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0a6c3f3 View commit details
    Browse the repository at this point in the history

  6. Removed RF phase bug (after ZOH->Lin)

    @cncastillo
    cncastillo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c98fb51 View commit details
    Browse the repository at this point in the history

  7. Plots now consider Δf

    @cncastillo
    cncastillo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8819526 View commit details
    Browse the repository at this point in the history

  8. Fixes eps causing incorrect block categorization.

    @cncastillo
    cncastillo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    44c8e31 View commit details
    Browse the repository at this point in the history

  9. Removed unecessary functions

    @cncastillo
    cncastillo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    516b909 View commit details
    Browse the repository at this point in the history

  10. Removed print in test

    @cncastillo
    cncastillo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    ed884c9 View commit details
    Browse the repository at this point in the history

  11. Added missing @Suppress in tests

    @cncastillo
    cncastillo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8d6f08f View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Temporal changes for testing pulseq first/last

    @beorostica
    beorostica committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a7fab0f View commit details
    Browse the repository at this point in the history

  2. More temporal changes for testing pulseq first/las

    @beorostica
    beorostica committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1a3b546 View commit details
    Browse the repository at this point in the history

  3. More x2 Temporal changes for testing pulseq first/last

    @beorostica
    beorostica committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    6a099dc View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. KomaMRIBase: Export is_X_on

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    c9677ee View commit details
    Browse the repository at this point in the history

  2. KomaMRIBase: Changed get_samples and constructors for type-stability

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    d0448a7 View commit details
    Browse the repository at this point in the history

  3. Renames get_tho to time and ampl, improved type stability

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    05cfda6 View commit details
    Browse the repository at this point in the history

  4. More efficient Seq constructor, and fix #203

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    c505bb2 View commit details
    Browse the repository at this point in the history

  5. Delay now creates Seq with seq.DUR=T

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    8c5f7fe View commit details
    Browse the repository at this point in the history

  6. RF flip angle now calculated using ampl, time, trapz

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    8fc52a5 View commit details
    Browse the repository at this point in the history

  7. trapz now works with vectors

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    47dea75 View commit details
    Browse the repository at this point in the history

  8. KomaBase test changes

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    a3cea4f View commit details
    Browse the repository at this point in the history

  9. KomaCore test do not use global variables anymore

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    940b828 View commit details
    Browse the repository at this point in the history

  10. KomaFiles Removed utils.jl

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    0c10aaa View commit details
    Browse the repository at this point in the history

  11. KomaFiles Pulseq read optimization and type stability #224

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    6176d03 View commit details
    Browse the repository at this point in the history

  12. KomaFiles Improved Pulseq compat tests

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    2b53c89 View commit details
    Browse the repository at this point in the history

  13. Fixed #203

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    682af57 View commit details
    Browse the repository at this point in the history

  14. KomaPlots Improved performance of plot_seq

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    1d589b9 View commit details
    Browse the repository at this point in the history

  15. KomaMRI: Fixed seq export to mat

    @cncastillo
    cncastillo committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    26b8d50 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. KomaMRI/Plots performance improvements plots #364

    @cncastillo
    cncastillo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d1573c2 View commit details
    Browse the repository at this point in the history

  2. Fixed DUR for older Pulseq versions

    @cncastillo
    cncastillo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a0ab60a View commit details
    Browse the repository at this point in the history

  3. Improved show_seq_blocks

    @cncastillo
    cncastillo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    18ce3ae View commit details
    Browse the repository at this point in the history

  4. KomaBase export time ampl freq

    @cncastillo
    cncastillo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4e0c670 View commit details
    Browse the repository at this point in the history

  5. KomaPlots give option to include RF freq inside phase (integration)

    @cncastillo
    cncastillo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    0bba7c5 View commit details
    Browse the repository at this point in the history

  6. Minor changes in Pulseq.jl [skip ci]

    @cncastillo
    cncastillo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    303e78c View commit details
    Browse the repository at this point in the history