Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ArbitraryMotion (continuation) #408

Merged
merged 115 commits into from
Jun 27, 2024

Leave `skipci`s as they were

5dcc8b8
Select commit
Loading
Failed to load commit list.
Merged

Optimize ArbitraryMotion (continuation) #408

Leave `skipci`s as they were
5dcc8b8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 27, 2024 in 0s

90.45% (target 90.00%)

View this Pull Request on Codecov

90.45% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 89.22156% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.45%. Comparing base (56fcedc) to head (5dcc8b8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   89.19%   90.45%   +1.26%     
==========================================
  Files          49       51       +2     
  Lines        2803     2796       -7     
==========================================
+ Hits         2500     2529      +29     
+ Misses        303      267      -36     
Files Coverage Δ
KomaMRIBase/src/KomaMRIBase.jl 100.00% <ø> (ø)
KomaMRIBase/src/datatypes/Phantom.jl 85.10% <100.00%> (+0.24%) ⬆️
...maMRIBase/src/datatypes/phantom/motion/NoMotion.jl 70.00% <100.00%> (-7.78%) ⬇️
...datatypes/phantom/motion/simplemotion/HeartBeat.jl 93.54% <100.00%> (+0.69%) ⬆️
...s/phantom/motion/simplemotion/PeriodicHeartBeat.jl 93.54% <100.00%> (+93.54%) ⬆️
...es/phantom/motion/simplemotion/PeriodicRotation.jl 91.66% <100.00%> (+1.19%) ⬆️
...phantom/motion/simplemotion/PeriodicTranslation.jl 85.71% <100.00%> (+3.89%) ⬆️
.../datatypes/phantom/motion/simplemotion/Rotation.jl 91.66% <100.00%> (+1.19%) ⬆️
...tatypes/phantom/motion/simplemotion/Translation.jl 85.71% <100.00%> (+3.89%) ⬆️
KomaMRIBase/src/timing/UnitTime.jl 100.00% <100.00%> (ø)
... and 10 more