Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial benchmarking implementation: steps to run benchmarks and comb… #418

Merged
merged 64 commits into from
Jul 3, 2024
Merged

Initial benchmarking implementation: steps to run benchmarks and comb… #418

merged 64 commits into from
Jul 3, 2024

Commits on Jun 26, 2024

  1. Initial benchmarking implementation: steps to run benchmarks and comb… 

    …ine results
    @rkierulf
    rkierulf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    288f6eb View commit details
    Browse the repository at this point in the history

  2. Make wait its own step

    @rkierulf
    rkierulf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c11d97a View commit details
    Browse the repository at this point in the history

  3. Change to only depend on KomaMRICore and KomaMRIBase

    @rkierulf
    rkierulf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dff363b View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @rkierulf
    rkierulf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    90bfb17 View commit details
    Browse the repository at this point in the history

  5. Shorten 3D Slice Benchmark

    @rkierulf
    rkierulf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a3dbffc View commit details
    Browse the repository at this point in the history

  6. Try again (core dumped error on previous benchmark run)

    @rkierulf
    rkierulf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a197f4b View commit details
    Browse the repository at this point in the history

  7. Try one more time

    @rkierulf
    rkierulf committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c4d6588 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Get rid of tuning (is only evaluating once anyway)

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1340a38 View commit details
    Browse the repository at this point in the history

  2. Attempt to fix artifact download issue

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    c633942 View commit details
    Browse the repository at this point in the history

  3. Fix issue with artifact destination and adjust benchmark parameters

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    21a5133 View commit details
    Browse the repository at this point in the history

  4. Pass --threads=auto to CPU benchmarks and instantiate project before … 

    …combining
    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6927ea0 View commit details
    Browse the repository at this point in the history

  5. Add more asserts

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3a04c23 View commit details
    Browse the repository at this point in the history

  6. Fix typo in aggregate.jl

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a70ff2c View commit details
    Browse the repository at this point in the history

  7. Fix last typo

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    22c5afc View commit details
    Browse the repository at this point in the history

  8. Add monorepo plugin

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a4197a1 View commit details
    Browse the repository at this point in the history

  9. Add debug log level (temporary)

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    30ee1f8 View commit details
    Browse the repository at this point in the history

  10. Make scripts executable

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4fd4c57 View commit details
    Browse the repository at this point in the history

  11. Change main to master

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2102de7 View commit details
    Browse the repository at this point in the history

  12. Try running in benchmark queue

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e789719 View commit details
    Browse the repository at this point in the history

  13. Move Intel, AMD, and Metal out of benchmark queue for now

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7d39fe4 View commit details
    Browse the repository at this point in the history

  14. Change monorepo plugin and fix file matching

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6eae676 View commit details
    Browse the repository at this point in the history

  15. Fix file matching again

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9b34064 View commit details
    Browse the repository at this point in the history

  16. Change aggregate.jl to not fail if only some benchmarks pass

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a4d1f37 View commit details
    Browse the repository at this point in the history

  17. Fix invalid assignment

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f902a34 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'master' of https://github.com/JuliaHealth/KomaMRI.jl in… 

    …to benchmark
    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    be1d32f View commit details
    Browse the repository at this point in the history

  19. Add github action

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    c138eea View commit details
    Browse the repository at this point in the history

  20. Add missing with

    @rkierulf
    rkierulf committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    65df46a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Add .github to paths temporarily

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6e9bfb0 View commit details
    Browse the repository at this point in the history

  2. Get rid of permissions part

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2b7b30c View commit details
    Browse the repository at this point in the history

  3. Fix output checks

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    dc78833 View commit details
    Browse the repository at this point in the history

  4. Add back permissions

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b932abd View commit details
    Browse the repository at this point in the history

  5. Remove metadata

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ae25033 View commit details
    Browse the repository at this point in the history

  6. Add missing outputs to steps

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    84b356e View commit details
    Browse the repository at this point in the history

  7. Trigger CI as cncastillo

    @cncastillo
    cncastillo authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ba92313 View commit details
    Browse the repository at this point in the history

  8. Refactor benchmarking scripts to run each CPU benchmark in separate job

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    03245f2 View commit details
    Browse the repository at this point in the history

  9. Add check for 'skip benchmarks' in github action

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    113e6b2 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'benchmark' of https://github.com/JuliaHealth/KomaMRI.jl … 

    …into benchmark
    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    42d1543 View commit details
    Browse the repository at this point in the history

  11. Fix issue loading CPU results in aggregate.jl

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    fa6561c View commit details
    Browse the repository at this point in the history

  12. Get rid of 16 CPU threads (benchmark queue machine only has 8 cores)

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    04ac61f View commit details
    Browse the repository at this point in the history

  13. Fix issues in Benchmark.yml

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6d8510d View commit details
    Browse the repository at this point in the history

  14. Add >2/dev/null to avoid printing find errors

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    85b8092 View commit details
    Browse the repository at this point in the history

  15. download_state -> download-state

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a951e85 View commit details
    Browse the repository at this point in the history

  16. Change CPU message slightly

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8bc9013 View commit details
    Browse the repository at this point in the history

  17. Try removing / at beginning of path

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    aa0f499 View commit details
    Browse the repository at this point in the history

  18. Change CPU message again

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a2cb24e View commit details
    Browse the repository at this point in the history

  19. Change to set JULIA_NUM_THREADS (to work later on for KernelAbstracti… 

    …ons)
    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    24e45bc View commit details
    Browse the repository at this point in the history

  20. Remove redundant conditional, add temporary print statement

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    203fb3c View commit details
    Browse the repository at this point in the history

  21. Remove --threads=auto to respect JULIA_NUM_THREADS

    @rkierulf
    rkierulf committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    240f433 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Add pwd and ls for debugging

    @rkierulf
    rkierulf committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    dfb2936 View commit details
    Browse the repository at this point in the history

  2. Change find path

    @rkierulf
    rkierulf committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ef987ee View commit details
    Browse the repository at this point in the history

  3. Add step to checkout branch

    @rkierulf
    rkierulf committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    843c7cd View commit details
    Browse the repository at this point in the history

  4. Checkout at beginning of job

    @rkierulf
    rkierulf committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    67259b8 View commit details
    Browse the repository at this point in the history

  5. Changed permissions to github_token to push to gh-pages

    @cncastillo
    cncastillo authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    0f528f4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into benchmark

    @cncastillo
    cncastillo authored Jun 29, 2024
    1 Configuration menu
    Copy the full SHA
    8f23b27 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Specify CUDA GPU for benchmarks

    @rkierulf
    rkierulf committed Jul 1, 2024
    1 Configuration menu
    Copy the full SHA
    dc4b62a View commit details
    Browse the repository at this point in the history

  2. Also specify AMD GPU

    @rkierulf
    rkierulf committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6cc6ae9 View commit details
    Browse the repository at this point in the history

  3. Switch to gfx1101 for AMD GPU

    @rkierulf
    rkierulf committed Jul 1, 2024
    1 Configuration menu
    Copy the full SHA
    d2265ea View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Change benchmark-data-dir-path to "bench" from "bench/dev"

    @rkierulf
    rkierulf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    124b2ad View commit details
    Browse the repository at this point in the history

  2. Change "bench" to "benchmarks"

    @rkierulf
    rkierulf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    27d4335 View commit details
    Browse the repository at this point in the history

  3. Change other places from bench to benchmarks

    @rkierulf
    rkierulf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ca8948b View commit details
    Browse the repository at this point in the history

  4. Separate pipeline into groups

    @rkierulf
    rkierulf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2180c04 View commit details
    Browse the repository at this point in the history

  5. Unindent env part

    @rkierulf
    rkierulf committed Jul 3, 2024
    1 Configuration menu
    Copy the full SHA
    f29f433 View commit details
    Browse the repository at this point in the history

  6. Delete lines with #TO-DO: remove this

    @rkierulf
    rkierulf committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    61fec64 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into benchmark

    @rkierulf
    rkierulf authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b4a5e88 View commit details
    Browse the repository at this point in the history