Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't forget to shift anchor at end of buffer #79

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

stevengj
Copy link
Member

Fixes #78: there was a bug where shiftdata! was failing to shift the anchor if it is located at the end of the buffer.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (00bf5e8) 85.82% compared to head (beba2f6) 85.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   85.82%   85.86%   +0.03%     
==========================================
  Files           5        5              
  Lines         381      382       +1     
==========================================
+ Hits          327      328       +1     
  Misses         54       54              
Impacted Files Coverage Δ
src/bufferedinputstream.jl 97.01% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KristofferC KristofferC merged commit 703f00f into master Aug 14, 2023
7 checks passed
@KristofferC KristofferC deleted the fixanchor branch August 14, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lost data from mark/reset?
3 participants