Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Zlib_jll instead of deps/build.jl #51

Closed
wants to merge 2 commits into from

Conversation

StefanKarpinski
Copy link
Member

No description provided.

@StefanKarpinski
Copy link
Member Author

Lol, the same PR has been made three times, once by @staticfloat, @KristofferC and now me.

@KristofferC
Copy link
Member

KristofferC commented Feb 7, 2020

Lol! 🤦‍♂️ 🤦‍♂️

@codecov-io
Copy link

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files           4        4           
  Lines         118      118           
=======================================
  Hits          106      106           
  Misses         12       12
Impacted Files Coverage Δ
src/CodecZlib.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c513b62...d2fe7b7. Read the comment docs.

@JackDunnNZ
Copy link

Bump, any chance this can be merged?

@KristofferC
Copy link
Member

Merged #49 instead since it also updated AppVeyor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants