Added support for WebP #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 91.71% 91.66% -0.05%
==========================================
Files 10 10
Lines 712 708 -4
==========================================
- Hits 653 649 -4
Misses 59 59 ☔ View full report in Codecov by Sentry. |
|
Merge #401 first for extra green check marks ✅ |
stemann
commented
Nov 4, 2024
|
@stemann Would it be helpful if I give you commit access here? |
|
Yes - that would be fine with me :-) |
Invited. Thank you! |
Also: * Moved QOI to Image formats section. * Changed AVI and WAV detectors (`detectavi`, and `detectwav`) to also use `detect_riff` - `detect_riff` is a bit more elaborate, as it also validates the RIFF payload size (little-endian UInt32 length of the file excluding fourcc, payload_length, and optional padding).
stemann
force-pushed
the
feature/webp
branch
from
bc5dd39
to
5974682
Compare
|
Will squash and merge, and release this later today if there are no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
detectavi, anddetectwav) to also usedetect_riff.-detect_riffis a bit more elaborate, as it also validates the RIFF payload size (little-endian UInt32 length of the file excluding fourcc, payload_length, and optional padding).AVI and WAV tests still pass.
Resolves #379.
Follow-up for ImageIO.jl#67