Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ply normals #91

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Ply normals #91

merged 4 commits into from
Jun 14, 2024

Conversation

spelufo
Copy link
Contributor

@spelufo spelufo commented May 10, 2024

Hi. This PR adds normals reading/writing for ply files.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 73.13433% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (1dfb00f) to head (413a70a).

Files Patch % Lines
src/io/ply.jl 73.13% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   78.93%   77.56%   -1.38%     
==========================================
  Files          10       10              
  Lines         527      575      +48     
==========================================
+ Hits          416      446      +30     
- Misses        111      129      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjkelly sjkelly merged commit 31857a3 into JuliaIO:master Jun 14, 2024
2 of 4 checks passed
@sjkelly
Copy link
Member

sjkelly commented Jun 14, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants