Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifications, more debug #49

Merged
merged 2 commits into from
Dec 27, 2021
Merged

Simplifications, more debug #49

merged 2 commits into from
Dec 27, 2021

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Dec 26, 2021 •
edited
Loading

  • some simplifications reading PNG_INFO_... flags, avoids further png_get_valid calls.
  • add a message saying that libpng_api.jl is auto-generated
  • added checks on valid_bKGD and valid_PLTE
  • simplify png_set_gamma logic (strictly equivalent)
  • more debugging info when JULIA_DEBUG=PNGFiles is set

@t-bltg t-bltg force-pushed the flags branch 2 times, most recently from c25387e to ab64ac8 Compare December 26, 2021 13:44
Drvi
Drvi approved these changes Dec 26, 2021
View reviewed changes
Copy link
Collaborator

@Drvi Drvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like a nice cleanup, thanks! 👍

src/io.jl Outdated Show resolved Hide resolved
@t-bltg t-bltg closed this Dec 26, 2021
@t-bltg t-bltg reopened this Dec 26, 2021
@Drvi
Copy link
Collaborator

Drvi commented Dec 26, 2021

Happy to merge this once the CI is green

@t-bltg
Copy link
Contributor Author

t-bltg commented Dec 27, 2021

Happy to merge this once the CI is green

It hangs :(

@t-bltg t-bltg closed this Dec 27, 2021
@t-bltg t-bltg reopened this Dec 27, 2021
@t-bltg t-bltg closed this Dec 27, 2021
@t-bltg t-bltg reopened this Dec 27, 2021
@Drvi Drvi merged commit 5d2b3d8 into JuliaIO:master Dec 27, 2021
@t-bltg t-bltg deleted the flags branch December 27, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drvi Drvi Drvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bltg @Drvi