fix read_data bug & use in read_standard_header #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 96.47% 96.05% -0.42%
==========================================
Files 4 4
Lines 681 685 +4
==========================================
+ Hits 657 658 +1
- Misses 24 27 +3
Continue to review full report at Codecov.
|
|
Wow, I seem to have hung all the 32-bit tests except for one. |
StefanKarpinski
force-pushed
the
sk/fix-read-data
branch
from
e835ba0
to
8d8a8aa
Compare
Also make sure that buffer views are constructed with `Int` ranges. Otherwise on 32-bit systems a 64-bit buffer view cannot be converted to a pointer, which causes problems. This entails checking for too large size values in a few places and casting to `Int` in a few more places where we know a value has to fit into a native `Int`.
StefanKarpinski
force-pushed
the
sk/fix-read-data
branch
from
8d8a8aa
to
3a212cc
Compare
StefanKarpinski
added a commit
that referenced
this pull request
May 11, 2021
Also make sure that buffer views are constructed with `Int` ranges. Otherwise on 32-bit systems a 64-bit buffer view cannot be converted to a pointer, which causes problems. This entails checking for too large size values in a few places and casting to `Int` in a few more places where we know a value has to fit into a native `Int`. (cherry picked from commit fdeec31)
ranocha
added a commit
to ranocha/Tar.jl
that referenced
this pull request
Sep 6, 2022
This improves type stability and fixes some invalidations when loading ArrayInterface.jl. It follows the approach of JuliaIO#112 to cast the optional argument of readbytes! to an Int.
ranocha
added a commit
to ranocha/Tar.jl
that referenced
this pull request
Sep 6, 2022
This improves type stability and fixes some invalidations when loading ArrayInterface.jl. It follows the approach of JuliaIO#112 to cast the optional argument of readbytes! to an Int.
staticfloat
pushed a commit
that referenced
this pull request
Sep 8, 2022
This improves type stability and fixes some invalidations when loading ArrayInterface.jl. It follows the approach of #112 to cast the optional argument of readbytes! to an Int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
read_data(::iO)method previously used a single call toreadbytes!which is incorrect sincereadbytes!only reads as many bytes as is currently available and doesn't block to get more data. This change fixes that bug by usingread!with a view buffer, which was only added to Base in Julia 1.4, so this also conditionally adds that method toread!if necessary.