Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom summary for Colorant SubArray #36

Merged
merged 1 commit into from
May 7, 2017
Merged

add custom summary for Colorant SubArray #36

merged 1 commit into from
May 7, 2017

Conversation

Evizero
Copy link
Member

@Evizero Evizero commented May 7, 2017

I realize this is type piracy, but I regularly wish this was custom behaviour when ImageCore is imported.

I thought proposing it couldn't hurt. Any thoughts?

@Evizero
Copy link
Member Author

Evizero commented May 7, 2017

Mhm, the 0.6 difference where Colon becomes Base.Slice(Base.OneTo(5)) is interesting. Unsure if special casing the display of : is still sensible then

@timholy
Copy link
Member

timholy commented May 7, 2017

I think we've decided to keep Slice to mean "the whole axis", so you could probably get away with it.

Personally, I think it may be worth floating the idea of moving ShowItLikeYouBuildIt into Base during the 0.7/1.0 development cycle, so I am in favor of such piracy when it counts as a useful experiment in printing.

@Evizero
Copy link
Member Author

Evizero commented May 7, 2017

I don't suppose you know the version number for the Slice introduction out of the top of your head, do you?

@timholy
Copy link
Member

timholy commented May 7, 2017

Nope. But do you know about contrib/commit-name.sh? Just search the log for the PR number that introduced Slice (mbauman is the author), and then point it to the merge commit.

@Evizero
Copy link
Member Author

Evizero commented May 7, 2017

will do. thanks for the tip.

@Evizero
Copy link
Member Author

Evizero commented May 7, 2017

Looks like JuliaLang/julia#19730

$ contrib/commit-name.sh 54ffc51
0.6.0-dev.2068

@codecov-io
Copy link

codecov-io commented May 7, 2017

Codecov Report

Merging #36 into master will decrease coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   94.96%   94.78%   -0.18%     
==========================================
  Files           9        9              
  Lines         556      556              
==========================================
- Hits          528      527       -1     
- Misses         28       29       +1
Impacted Files Coverage Δ
src/show.jl 100% <100%> (ø) ⬆️
src/colorchannels.jl 95.88% <0%> (-0.59%) ⬇️
src/ImageCore.jl 100% <0%> (ø) ⬆️
src/stackedviews.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db10f8...e5422d3. Read the comment docs.

@Evizero
Copy link
Member Author

Evizero commented May 7, 2017

A little odd that coverage is decreased in an unaffected file.

@timholy timholy merged commit c686fc1 into master May 7, 2017
@timholy
Copy link
Member

timholy commented May 7, 2017

I like, thanks!

@Evizero Evizero deleted the cs/subarray branch May 7, 2017 16:39
@Evizero
Copy link
Member Author

Evizero commented May 9, 2017

mind if we tag a patch release for this change? JuliaImages/ImageTransformations.jl#27 builds on this. (It's not a hard requirement though. So no worries)

@timholy
Copy link
Member

timholy commented May 9, 2017

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants