Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for various Julia versions #89

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Fixes for various Julia versions #89

merged 2 commits into from
Dec 21, 2018

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 21, 2018

The first commit gets the tests passing with the new IdentityUnitRange on Julia 1.1. The second is due to my failure to tag JuliaLang/julia#30164 with a backport label.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #89 into master will increase coverage by 20.48%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #89       +/-   ##
===========================================
+ Coverage   62.56%   83.05%   +20.48%     
===========================================
  Files           8        8               
  Lines        1074     1086       +12     
===========================================
+ Hits          672      902      +230     
+ Misses        402      184      -218
Impacted Files Coverage Δ
src/kernel.jl 96.9% <100%> (+14.43%) ⬆️
src/ImageFiltering.jl 78.57% <50%> (-1.43%) ⬇️
src/utils.jl 64.28% <0%> (+10.71%) ⬆️
src/kernelfactors.jl 75.83% <0%> (+16.16%) ⬆️
src/imfilter.jl 84.16% <0%> (+20.33%) ⬆️
src/border.jl 84.66% <0%> (+20.91%) ⬆️
src/specialty.jl 88.23% <0%> (+23.52%) ⬆️
src/mapwindow.jl 79.03% <0%> (+29.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b66231...29a873a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #89 into master will increase coverage by 20.48%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #89       +/-   ##
===========================================
+ Coverage   62.56%   83.05%   +20.48%     
===========================================
  Files           8        8               
  Lines        1074     1086       +12     
===========================================
+ Hits          672      902      +230     
+ Misses        402      184      -218
Impacted Files Coverage Δ
src/kernel.jl 96.9% <100%> (+14.43%) ⬆️
src/ImageFiltering.jl 78.57% <50%> (-1.43%) ⬇️
src/utils.jl 64.28% <0%> (+10.71%) ⬆️
src/kernelfactors.jl 75.83% <0%> (+16.16%) ⬆️
src/imfilter.jl 84.16% <0%> (+20.33%) ⬆️
src/border.jl 84.66% <0%> (+20.91%) ⬆️
src/specialty.jl 88.23% <0%> (+23.52%) ⬆️
src/mapwindow.jl 79.03% <0%> (+29.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b66231...29a873a. Read the comment docs.

@timholy timholy merged commit 51c608c into master Dec 21, 2018
@timholy timholy deleted the teh/identityur branch December 21, 2018 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant