one->oneunit for CartesianIndex #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, looks like I never requested JuliaLang/julia#29442 be backported to 1.0. One option would be to drop further support for Julia 1.0. Alternatively we could define a |
johnnychen94
force-pushed
the
teh/oneunit
branch
from
6559c57
to
6295f22
Compare
| @@ -0,0 +1,7 @@ | |||
| if VERSION <= v"1.0.5" | |||
There was a problem hiding this comment.
I notice there's a backport-1.0 label in JuliaLang/julia#29442, I assume oneunit(::CartesianIndex) will be available for Julia 1.0.6, if there is another release?
There was a problem hiding this comment.
I added that backport label relatively recently, if memory serves. Hopefully that means it will be available; if not we can change the bounds here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49