Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial (trivial) implementation of flood_fill #75

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Initial (trivial) implementation of flood_fill #75

merged 4 commits into from
Sep 2, 2021

Conversation

timholy
Copy link
Member

@timholy timholy commented Sep 2, 2021

Also adds window-iterators to traverse different neighborhood patterns.

Also deprecates the Vector{Int} method of specifying kernel (window) sizes.

@timholy
Initial (trivial) implementation of flood_fill
c849bf7 
Also adds window-iterators to traverse different neighborhood patterns.
@timholy
Fix doctests on Julia 1.0
a060d60
johnnychen94
johnnychen94 reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the algorithm so just one trivial comment.

src/core.jl Outdated Show resolved Hide resolved
@timholy timholy merged commit 82c79cd into master Sep 2, 2021
@timholy timholy deleted the teh/flood branch September 2, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnychen94 johnnychen94 johnnychen94 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timholy @johnnychen94