Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect_headers: sort headers list #421

Merged
merged 3 commits into from
Mar 12, 2023
Merged

detect_headers: sort headers list #421

merged 3 commits into from
Mar 12, 2023

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Mar 11, 2023

@t-bltg t-bltg mentioned this pull request Mar 11, 2023
Closed
@Gnimuc
Copy link
Member

Gnimuc commented Mar 11, 2023

If Julia's Set is not deterministic between versions, then it's not a problem of Clang. I'd like to keep the dependency graph minimal.

@t-bltg
Copy link
Contributor Author

t-bltg commented Mar 11, 2023 •
edited
Loading

No, it's non-deterministic for a single julia version:

$ julia generator.jl 1.9
$ julia generator.jl 1.9  # re-run, signatures changed

How about using a Vector and use unique! afterwards ?
Or use sort ?

@Gnimuc
Copy link
Member

Gnimuc commented Mar 11, 2023

Is it same with 1.8?

@Gnimuc
Copy link
Member

Gnimuc commented Mar 11, 2023

How about using a Vector and use unique! afterwards ?
Or use sort ?

yes, this is a good idea.

@t-bltg t-bltg changed the title use OrderedSet instead of Set detect_headers: sort headers list Mar 11, 2023
@Gnimuc Gnimuc merged commit 31812fb into JuliaInterop:master Mar 12, 2023
@t-bltg t-bltg deleted the order branch March 12, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnimuc Gnimuc Gnimuc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deterministic generator
2 participants
@t-bltg @Gnimuc