Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the concrete RefValue type to avoid method ambiguities #474

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Use the concrete RefValue type to avoid method ambiguities #474

merged 2 commits into from
Mar 7, 2024

Commits on Mar 7, 2024

  1. Rename ExprDAG.partial_nodes to ExprDAG.partially_emitted_nodes

    @JamesWrigley
    JamesWrigley committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ab0b3d5 View commit details
    Browse the repository at this point in the history

  2. Use the concrete RefValue type to avoid method ambiguities 

    On 1.11 there's a new `unsafe_convert(::Type{Ptr{T}}, a::GenericMemoryRef)`
method which causes ambiguity errors with just Ref, so now we use the concrete
RefValue.
    @JamesWrigley
    JamesWrigley committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3d8b32e View commit details
    Browse the repository at this point in the history