Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for automatically calling unsafe_load() in getproperty() #502

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for automatically calling unsafe_load() in getproperty() #502

wants to merge 5 commits into from

Commits on Aug 20, 2024

  1. Always delete old BinaryBuilder tarballs before building 

    Old tarballs from previous Julia versions would otherwise screw up the use of
`only()` to find the latest tarball.
    @JamesWrigley
    JamesWrigley committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4b9d282 View commit details
    Browse the repository at this point in the history

  2. Move the bitfield get/set code into their own functions 

    This makes them easier to re-use elsewhere.
    @JamesWrigley
    JamesWrigley committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a226276 View commit details
    Browse the repository at this point in the history

  3. Add support for automatically calling unsafe_load() in getproperty() 

    Copying the description from the code:
> By default the getproperty!(x::Ptr, ::Symbol) methods created for wrapped
> types will return pointers (Ptr{T}) to the struct fields. That behaviour is
> useful for accessing nested struct fields but it does require explicitly
> calling unsafe_load() every time. When enabled this option will automatically
> call unsafe_load() for you *except on nested struct fields and arrays*, which
> should make explicitly calling unsafe_load() unnecessary in most cases.
    @JamesWrigley
    JamesWrigley committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d901cb7 View commit details
    Browse the repository at this point in the history

  4. Revert "Remove test workaround (#504)" 

    This reverts commit 9c77fd6. Now the tests fail
for a different reason :')
    @JamesWrigley
    JamesWrigley committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5f8a145 View commit details
    Browse the repository at this point in the history

  5. fixup! Add support for automatically calling unsafe_load() in getprop… 

    …erty()
    @JamesWrigley
    JamesWrigley committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ff9c955 View commit details
    Browse the repository at this point in the history